Fix argument checks #222
Open
Fix argument checks #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasm91
suggested changes
Mar 3, 2025
samhatfield
force-pushed
the
fix_argument_checks
branch
from
de9cf5e to
0737d30
Compare
lukasm91
approved these changes
Mar 4, 2025
samhatfield
force-pushed
the
fix_argument_checks
branch
2 times, most recently
from
85b67b3 to
be7e90b
Compare
This check was failing when "--vordiv --uvders" was enabled. There may be a case in the IFS when we pass a PGPUV array with more wind elements than required to INV_TRANS. This is certainly the case in the benchmark program, although I think that's just because the code is wrong. The --vordiv option doesn't enable grid point vorticity and divergence, as one would expect from the way the PGPUV array is sized. It just enables transforming of vorticity and divergence to U and V.
samhatfield
force-pushed
the
fix_argument_checks
branch
from
be7e90b to
a2427ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #220.