Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asre1b_mod fix #35

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Conversation

PaulMullowney
Copy link
Contributor

Missing collapse statement in the omp code improves performance in th…e ectrans benchmark

@FussyDuck
Copy link

FussyDuck commented Aug 28, 2023

CLA assistant check
All committers have signed the CLA.

@wdeconinck wdeconinck requested a review from anmrde August 29, 2023 06:43
@PaulMullowney
Copy link
Contributor Author

I don't understand what else I need to do with the contributor license agreement. I've tried to sign it.

@wdeconinck
Copy link
Collaborator

I don't understand what else I need to do with the contributor license agreement. I've tried to sign it.

Could it be that the email address of the particular commit is not registered in GitHub? That could explain it.

@PaulMullowney
Copy link
Contributor Author

I don't understand what else I need to do with the contributor license agreement. I've tried to sign it.

Could it be that the email address of the particular commit is not registered in GitHub? That could explain it.

Your comment on this thread came to my AMD email address.

@wdeconinck
Copy link
Collaborator

I see in the commit:

commit cee87b854d5ae527fdc6c5cb246e9082a6478140 (origin/asre1b_mod_fix)
Author: Paul Mullowney <[email protected]>
Date:   Mon Aug 28 18:36:54 2023 -0400

This email address listed above is not registered in your GitHub account, so GitHub does not know this is you. Also when I hover over the committer of that commit, it is not a clickable link, which it normally should be.
You can have multiple email addresses linked to your GitHub account, that is not a problem.

@PaulMullowney
Copy link
Contributor Author

I see in the commit:

commit cee87b854d5ae527fdc6c5cb246e9082a6478140 (origin/asre1b_mod_fix)
Author: Paul Mullowney <[email protected]>
Date:   Mon Aug 28 18:36:54 2023 -0400

This email address listed above is not registered in your GitHub account, so GitHub does not know this is you. Also when I hover over the committer of that commit, it is not a clickable link, which it normally should be. You can have multiple email addresses linked to your GitHub account, that is not a problem.

I think I have it fixed now.

@wdeconinck wdeconinck merged commit 9afc482 into ecmwf-ifs:amdgpu Sep 1, 2023
10 checks passed
@wdeconinck
Copy link
Collaborator

Thanks @PaulMullowney for this contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants