New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run with bound checking #29

Merged

pmarguinaud merged 1 commit into ecmwf-ifs:main from pmarguinaud:bound-checking

Feb 23, 2024

Collaborator

pmarguinaud commented Feb 23, 2024

Because of this small piece of code (generated from field_RANKSUFF_data_module.fypp) :

  ITHIS_STRIDE = LOC (PTR (LB(1)+1, LB(2), LB(3), LB(4))) - LOC (PTR (LB(1), LB(2), LB(3), LB(4)))
  IF (AFTER < 1) THEN 
    ISIZE = 1
    IF (SIZE(PTR, 1) /= 1 .AND. IPREVIOUS_STRIDE * ISIZE /= ITHIS_STRIDE) THEN

Field API could not run with bound checking enabled : the access to PTR in the LOC intrinsic could go out of bounds when SIZE (PTR, 1) == 1.

This PR solves the issue.


          Fix out of bounds access in LOC function

7f633d5

pmarguinaud requested a review from awnawab

February 23, 2024 10:42

awnawab approved these changes

View reviewed changes

Collaborator

awnawab left a comment

Well spotted and cleanly fixed! Thanks for this, G2G 👍

pmarguinaud merged commit db50169 into ecmwf-ifs:main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet