Enable fields with a last lower bound different from 1 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is different from one
awnawab
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Thanks a lot for this @pmarguinaud! This makes the usage of owned fields more flexible and makes the behaviour of the persistent option more coherent 👍
awnawab
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to enable fields with a last dimension (usually the block dimension) different from 1; in particular, we test gather/scatter and reshuffle functionnalities on these fields.
Tested in ARPEGE t798, double precision : we run this test case on 12 NVIDIA V100. Using temporaries with block range allowed us to decrease the amount of required memory by a factor of 2. Each MPI task has 72058 = 2252 x 32 points, we process the 2252 blocks in 4 batches of 640 blocks.