Pull back data to legacy structures on device #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awnawab
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Hi @pmarguinaud. Enabling FIELD_API to work with legacy/manually offloaded code is a much needed and extremely welcome feature addition. It is also very well timed, as we are looking to soon integrate offloaded ecTrans with offloaded ecPhys. Many many thanks 🙌
| !$acc end kernels | ||
|
|
||
| !$acc enter data create (GMV) | ||
| !$acc update device (GMV) |
There was a problem hiding this comment.
[no action] Since GMV has been allocated by the time we get here, we can simply do !$acc enter data copyin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARPEGE/IFS field data are now encapsulated with Field API structures in the grid-point calculations; however, in the spectral calculations, these data are still represented by old GMV and GFL arrays.
This implies that we need to implement a fast mean of moving GFL/GMV back and forth between new Field API data structures and GMV/GFL arrays allocated on the device.
This PR implements such a mechanism, which is designed to be flexible enough to be compatible with a traversal of large data structures such as YDVARS.
The test case test_legacy.F90 illustrates this mechanism.