Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Only search for OpenACC if the corresponding option is active #60

Merged
merged 1 commit into from
Sep 25, 2024
Merged

CMake: Only search for OpenACC if the corresponding option is active #60

merged 1 commit into from
Sep 25, 2024

Conversation

reuterbal
Copy link
Collaborator

This triggers the CMake search for the programming model only if the corresponding ecbuild option is activated.

@FussyDuck
Copy link

FussyDuck commented Sep 24, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@awnawab awnawab requested a review from dareg September 24, 2024 12:25
awnawab
awnawab approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@awnawab awnawab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this extra safety check, looks good to me 👍 @dareg could you please confirm if this is safe for your builds too?

@awnawab awnawab merged commit c078dbe into ecmwf-ifs:main Sep 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dareg dareg dareg approved these changes

@awnawab awnawab awnawab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reuterbal @FussyDuck @dareg @awnawab