Serialise job (#19) #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eModel.copy. Fixed bug in threads_per_node.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
+ Coverage 81.38% 81.66% +0.28%
==========================================
Files 54 54
Lines 3223 3267 +44
==========================================
+ Hits 2623 2668 +45
+ Misses 600 599 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
reuterbal
requested changes
Mar 7, 2025
| @@ -48,52 +48,51 @@ def threads_per_node(self): | |||
| The number of logical cores per node (threads). This value is automatically derived | |||
| from the above properties. | |||
| """ | |||
| return self.cores_per_node * self.threads_per_core | |||
| return self.cores_per_node() * self.threads_per_core | |||
There was a problem hiding this comment.
I think the API would be nicer if we declared cores_per_node (and for consistency) threads_per_node as properties. Then the look and feel of reading Job.threads_per_core and Job.threads_per_node is the same, even though one is derived from the other (which is an implementation detail that a user doesn't need to care about).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed copy to clone to avoid clash with pydantic.BaseModel.copy. Fixed bug in threads_per_node.