ArgSizeMismatchRule: small fixes after PR review

ecmwf-ifs · Jul 19, 2023 · 2073856 · 2073856
1 parent 16f022a
commit 2073856
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/lint_rules/lint_rules/debug_rules.py b/lint_rules/lint_rules/debug_rules.py
@@ -124,12 +124,7 @@ def check_subroutine(cls, subroutine, rule_report, config, **kwargs):
                 continue
 
             arg_map = {carg: rarg for rarg, carg in call.arg_iter()}
-
-            # combine args and kwargs into single iterable
-            arguments = call.arguments
-            arguments += as_tuple([arg for kw, arg in call.kwarguments])
-
-            for arg in arguments:
+            for arg in arg_map:
 
                 if isinstance(arg_map[arg], Scalar):
                     dummy_arg_size = as_tuple(IntLiteral(1))
@@ -139,8 +134,7 @@ def check_subroutine(cls, subroutine, rule_report, config, **kwargs):
                            for dim in arg_map[arg].shape if isinstance(dim, RangeIndex)):
                         continue
                     dummy_arg_size = cls.get_explicit_arg_size(arg_map[arg], arg_map[arg].shape)
-
-                dummy_arg_size = SubstituteExpressions(dict(call.arg_iter())).visit(dummy_arg_size)
+                    dummy_arg_size = SubstituteExpressions(dict(call.arg_iter())).visit(dummy_arg_size)
 
                 # TODO: skip string literal args
                 if isinstance(arg, StringLiteral):

diff --git a/lint_rules/tests/test_debug_rules.py b/lint_rules/tests/test_debug_rules.py
@@ -16,7 +16,7 @@
 
 
 pytestmark = pytest.mark.skipif(not available_frontends(),
-                                reason='Suitable frontend not available')
+                                reason='Supported frontend not available')
 
 
 @pytest.fixture(scope='module', name='rules')