Single declarations for hoisted variables in recursive hoist transformation (fixes #143) #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/144/index.html |
reuterbal
force-pushed
the
143-hoist-temporaries-declarations
branch
from
ca2e527
to
cd325b7
Compare
Codecov Report
@@ Coverage Diff @@
## main #144 +/- ##
=======================================
Coverage 92.10% 92.10%
=======================================
Files 89 89
Lines 16512 16515 +3
=======================================
+ Hits 15208 15211 +3
Misses 1304 1304
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mlange05
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue are declarations of multiple temporaries in a single statement, of which not all are hoisted. The hoisted temporaries receive an additional
intentattribute, which means these need to be declared separately from non-hoisted variables.This fixes the issue by using the
single_variable_declarationutility to create separate declarations for hoisted temporaries.Piggy-backed is a small fix to ensure case-insensitive behaviour in a call lookup, which showed up when using the supplied test.