Loki_transform: Re-instate argument shape derivation in convert
#149
Conversation
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/149/index.html |
Codecov Report
@@ Coverage Diff @@
## main #149 +/- ##
=======================================
Coverage 92.10% 92.10%
=======================================
Files 90 90
Lines 16628 16628
=======================================
Hits 15315 15315
Misses 1313 1313
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Uncontroversial and looks good. Sorry for not spotting this on the original PR.
Only question would be whether to opt for a more descriptive option name, like --derive-argument-array-shape? Similarly to --remove-openmp, --removed-derived-args, --trim-vector-sections I find a verb helps to convey the implication.
scripts/loki_transform.py
Outdated
| @@ -104,12 +104,12 @@ def cli(debug): | |||
| help="Generate offload instructions for global vars imported via 'USE' statements.") | |||
| @click.option('--remove-derived-args/--no-remove-derived-args', default=False, | |||
| help="Remove derived-type arguments and replace with canonical arguments") | |||
| @click.option('--argument-array-shape/--no-argument-array-shape', default=False, | |||
| @click.option('--derive-argument-array-shape/--no-argument-array-shape', default=False, | |||
There was a problem hiding this comment.
Shouldn't this be --no-derive-argument-array-shape now as well? (Sorry, bit of a mouthful)
This also turns the option off by default.
reuterbal
force-pushed
the
naml-convert-argument-array-shape
branch
from
083a672
to
9cf5f51
Compare
|
Rebased over latest main, resolving conflicts. Further CMake refactoring filed as separate PR (#166) against this branch. |
…ay-shape CMake refactoring for loki_transform
|
Ok, I think this is now GTG for merging once the CI comes back green. |
Post-hoc fix to an oversight in PR #142. When removing the dedicated
ecphysentry point, we dropped the argument array shape transformation that is used to replace:dimensions with explicitly named dimensions in the surface modules of the code. This PR adds an option (on by default) to theconvertentry point that re-enables this behaviour.