do not use size_limit #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The adaptor has its own way to measure request size, that must be very fast, as it is called in every click in the forms. We simplify our code removing this.
# Conflicts: # cdsobs/ingestion/serialize.py
# Conflicts: # cdsobs/ingestion/serialize.py
|
This goes with #44 We had two costs estimated, one in the adaptor, inherited, and another in the observations api backend, that was called when querying the catalogue to get the list of assets. We removed the second, and improved the first adding a simple area weighting to take into account the “area” keyword in the request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The adaptor has its own way to measure request size, that must be very fast, as it is called in every click in the forms. We simplify our code removing this.