-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: compare lam statistics #203
base: main
Are you sure you want to change the base?
Conversation
All failed checks are related to issues and code not affected by this PR. |
Caution This pull request contains changes to GitHub workflows! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, just some stylistic changes, so that the command follow the same style as the others (use of hyphens in name instead of underscore and came case):
- Rename the command to
compare-lam
- Rename arguments such as
--num_dates
to--number-of-dates
- Use single letter for short option (e.g.
-D
instead of-nd
)
Also, can you move the import cartopy
, import prettytable
etc, from the top of the file into the functions/methods using them, so we avoid loading them unnecessarily when not calling the command. This is because all the commands are loaded even if they are not called.
Description
Adding a new command to compare statistics withing a LAM region across 2 datasets.
Type of Change
Issue Number
Closes #202
Code Compatibility
Code Performance and Testing
Dependencies
prettytable
print_color
termcolor
Documentation
Added New command: compareLAM
📚 Documentation preview 📚: https://anemoi-datasets--203.org.readthedocs.build/en/203/