Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature list depth option #34

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Conversation

mcakircali
Copy link
Contributor

@mcakircali mcakircali commented Aug 8, 2024

most of this PR was merged as part of schema rule
only those tests (from mars suite) are to be merged
tests are taking longer than avg.

    Start 285: test_fdb_tools_list_all
1/8 Test #285: test_fdb_tools_list_all ............   Passed   11.11 sec
    Start 286: test_fdb_tools_list_all_full
2/8 Test #286: test_fdb_tools_list_all_full .......   Passed    8.65 sec
    Start 287: test_fdb_tools_list_location
3/8 Test #287: test_fdb_tools_list_location .......   Passed    1.39 sec
    Start 288: test_fdb_tools_list_masking
4/8 Test #288: test_fdb_tools_list_masking ........   Passed    5.85 sec
    Start 289: test_fdb_tools_list_minimum_keys
5/8 Test #289: test_fdb_tools_list_minimum_keys ...   Passed    1.56 sec
    Start 290: test_fdb_tools_list_porcelain
6/8 Test #290: test_fdb_tools_list_porcelain ......   Passed    3.34 sec
    Start 291: test_fdb_tools_list_ranges
7/8 Test #291: test_fdb_tools_list_ranges .........   Passed    7.17 sec
    Start 292: test_fdb_tools_list_depth
8/8 Test #292: test_fdb_tools_list_depth ..........   Passed    0.94 sec

@mcakircali mcakircali requested a review from simondsmart August 8, 2024 08:44
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.50%. Comparing base (a4a4fda) to head (c5bb121).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #34      +/-   ##
===========================================
+ Coverage    61.48%   61.50%   +0.01%     
===========================================
  Files          275      275              
  Lines        15253    15253              
  Branches      1556     1556              
===========================================
+ Hits          9379     9381       +2     
+ Misses        5874     5872       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcakircali mcakircali marked this pull request as ready for review August 8, 2024 08:57
src/fdb5/api/helpers/ListElement.cc Outdated Show resolved Hide resolved
src/fdb5/api/helpers/ListElement.cc Outdated Show resolved Hide resolved
src/fdb5/api/helpers/ListElement.h Outdated Show resolved Hide resolved
src/fdb5/api/helpers/ListElement.h Outdated Show resolved Hide resolved
src/fdb5/api/helpers/ListElement.h Outdated Show resolved Hide resolved
src/fdb5/tools/fdb-list.cc Outdated Show resolved Hide resolved
src/fdb5/tools/fdb-list.cc Outdated Show resolved Hide resolved
tests/fdb/api/test_fdb_c.cc Outdated Show resolved Hide resolved
tests/fdb/api/test_fdb_c.cc Outdated Show resolved Hide resolved
src/fdb5/api/local/ListVisitor.h Outdated Show resolved Hide resolved
@mcakircali mcakircali requested a review from simondsmart August 14, 2024 13:38
@mcakircali mcakircali force-pushed the feature/list-depth-option branch 2 times, most recently from c78d9f9 to 495bdb7 Compare February 10, 2025 21:46
@mcakircali mcakircali force-pushed the feature/list-depth-option branch from 495bdb7 to c5bb121 Compare February 10, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants