Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(input-value): make useInputValue more compatible #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SyMind
Copy link
Contributor

@SyMind SyMind commented Apr 22, 2021

@otakustay
Copy link
Member

I love this feature, and useInputValue can be generic (default to string) since custom components may provide value and onChange in custom types, and strings can also be literal unions for checkbox and radio

@SyMind
Copy link
Contributor Author

SyMind commented Apr 26, 2021

You are right, with generic is better.

@otakustay
Copy link
Member

This is a breaking change since initialValue no longer defaults to empty string, I need some more time to think about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants