fix: prevent duplicated tags for same order (check custom field)

debug unexpected response from mandabem api on tag creation
ecomplus · Sep 9, 2024 · e27e6c9 · e27e6c9
1 parent 9528018
commit e27e6c9
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 4 deletions.
diff --git a/functions/lib/mandabem/create-tag.js b/functions/lib/mandabem/create-tag.js
@@ -1,3 +1,4 @@
+const { logger } = require('firebase-functions')
 const axios = require('axios')
 const qs = require('querystring')
 
@@ -78,8 +79,8 @@ module.exports = ({ appSdk, storeId, auth }, {
                 }
               }
             ).then(({ data }) => {
-              console.log('Tag created with success', order._id)
               if (String(data?.resultado?.sucesso) === 'true') {
+                logger.info(`Tag created with success ${order._id}`)
                 const tagId = String(data.resultado.envio_id)
                 const customFields = shippingLine.custom_fields || []
                 customFields.push({
@@ -94,7 +95,11 @@ module.exports = ({ appSdk, storeId, auth }, {
                   auth
                 )
               }
-              return data
+              logger.info(`Unexpected response for ${order._id} tag`, {
+                order,
+                data
+              })
+              return null
             }).catch(console.error))
         }
       }

diff --git a/functions/routes/ecom/webhook.js b/functions/routes/ecom/webhook.js
@@ -1,3 +1,4 @@
+const { logger } = require('firebase-functions')
 const getAppData = require('./../../lib/store-api/get-app-data')
 const createMandaBemTag = require('./../../lib/mandabem/create-tag')
 
@@ -25,6 +26,19 @@ const parseStatus = (status) => {
   }
 }
 
+const getShippingCustomField = (order, field) => {
+  if (order.shipping_lines) {
+    for (let i = 0; i < order.shipping_lines.length; i++) {
+      const shippingLineFields = order.shipping_lines[i].custom_fields
+      const customField = shippingLineFields?.find(custom => custom.field === field)
+      if (customField) {
+        return customField.value
+      }
+    }
+  }
+  return false
+}
+
 exports.post = ({ appSdk }, req, res) => {
   // receiving notification from Store API
   const { storeId } = req
@@ -68,7 +82,10 @@ exports.post = ({ appSdk }, req, res) => {
 
     .then(({ response }) => {
       const order = response.data
-      console.log(`Shipping tag for #${storeId} ${order._id}`)
+      if (getShippingCustomField(order, 'mandabem_id')) {
+        return null
+      }
+      logger.info(`Shipping tag for #${storeId} ${order._id}`)
       return createMandaBemTag({ appSdk, storeId, auth }, {
         mandaBemId,
         mandaBemKey,
@@ -83,7 +100,6 @@ exports.post = ({ appSdk }, req, res) => {
     })
 
     .catch(err => {
-      console.log('didnt workout at any point', err)
       if (err.name === SKIP_TRIGGER_NAME) {
         // trigger ignored by app configuration
         res.send(ECHO_SKIP)