Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix erase #94

Merged
merged 6 commits into from
Jul 17, 2024
Merged

Fix erase #94

merged 6 commits into from
Jul 17, 2024

Conversation

lemire
Copy link
Collaborator

@lemire lemire commented Jul 17, 2024

The code should be self-explanatory...

@lemire lemire mentioned this pull request Jul 17, 2024
Closed
@lemire lemire requested a review from eddelbuettel July 17, 2024 15:38
@eddelbuettel
Copy link
Owner

Very very nice. Can I get you to add a quick ChangeLog entry as you kindly did for #92 ?

@eddelbuettel eddelbuettel self-requested a review July 17, 2024 15:59
eddelbuettel
eddelbuettel reviewed Jul 17, 2024
View reviewed changes
Copy link
Owner

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry if you could. Else I can toss one in whem I increment the version.

@lemire
Copy link
Collaborator Author

lemire commented Jul 17, 2024

Please add a changelog entry if you could. Else I can toss one in whem I increment the version.

I did so.

@eddelbuettel eddelbuettel merged commit b8ff08e into eddelbuettel:master Jul 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddelbuettel eddelbuettel eddelbuettel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lemire @eddelbuettel