grafana: Configure dashboards in json #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposes a new flow for developing the dashboards, where instead of managing them inside
grafana.db, they are provisioned from a directory containing the dashboard jsons. This avoids conflicts in thegrafana.dband makes changes more reviewable. When editing a dashboard, this dialog is now shown:So you can no longer directly save the dashboard, but you have to copy paste it back into the file. Grafana listens for changes in the file and will update the live dashboard.
This also includes the script I used to pull the existing dashboards (don't be impressed, ChatGPT wrote it). It might prove useful again if we need to pull dashboards from the cloud through the Grafana API to commit them back to this repo.