Derive marble private secrets using marble type in addition to UUID #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for marblerun-docs canceled.
|
Signed-off-by: Daniel Weiße <[email protected]>
daniel-weisse
force-pushed
the
dw/uuid-key-derivation
branch
from
2699864
to
7747896
Compare
thomasten
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a marble requests a private secret, that secret is derived from the coordinators root key using HKDF with the Marble's UUID and the name of the secret being used as salt for the derivation.
This means that any two marbles with the same UUID will receive the same secrets, even if they have different marble types.
Since this behavior is not always clear to users, and they should use shared secrets to facilitate this secret instead, this PR updates the secret generation code to include the name of the marble as Info parameter for the HKDF function so any two Marbles of different types will receive different secrets even if they have the same UUID.
Proposed changes
DisableSecretBindingon a Marble