Allow specifying accepted avisories for SWHardeningNeeded TCB status
#733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for marblerun-docs canceled.
|
Signed-off-by: Daniel Weiße <[email protected]>
daniel-weisse
force-pushed
the
dw/advisory-whitelist
branch
from
01cca91
to
152c8b3
Compare
thomasten
requested changes
Sep 27, 2024
| @@ -47,6 +47,10 @@ func (v *ERTValidator) Validate(givenQuote []byte, cert []byte, pp quote.Package | |||
| v.log.Error("TCB Advisories", zap.Error(report.TCBAdvisoriesErr)) | |||
| } | |||
|
|
|||
| if notAccepted := tcb.CheckAdvisories(report.TCBStatus, report.TCBAdvisories, pp.AcceptedAdvisories); len(notAccepted) > 0 { | |||
| return fmt.Errorf("TCB status %s contains advisories not accepted by configuration: %s", report.TCBStatus, notAccepted) | |||
There was a problem hiding this comment.
Will this be logged somewhere, linked to the package?
We should maybe generally check and (if needed) improve the logging of Marble activations in case of different errors.
There was a problem hiding this comment.
We log any failed Marble verification attempts in coordinator/core/marbleapi.go. That log statement contains the error returned by this package.
Is there any information missing you would prefer to be logged in ertvalidator.go?
There was a problem hiding this comment.
I'm not sure, but I think I've seen log outputs of failed activations where we could have given more details. However, this is out of scope. I may revisit this myself at some point.
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
thomasten
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#729 added support for reading the Security Advisories if attestation failed due to invalid TCB status.
This PR builds on that to allow users to specify just specific advisories when the reported TCB status is
SWHardeningNeededProposed changes
--accepted-advisorieswhich allows specifying a list of Intel Security Advisories to accept if the Coordinator's TCB status isSWHardeningNeeded. If not set, all advisories are acceptedPackages.AcceptedAdvisorieswhich allows specifying a list of Intel Security Advisories to accept if the package's TCB status isSWHardeningNeeded. If not set, all advisories are acceptednilerror if parsing the advisory list of a report failed