Skip to content

Commit

Permalink
ACPI: Unconditionally mask off PCIe native hot plug control
Browse files Browse the repository at this point in the history
We don't actually support hot plug and this causes lockups in Windows.

Signed-off-by: Mario Bălănică <[email protected]>
  • Loading branch information
mariobalanica committed Mar 1, 2024
1 parent ba8fbee commit 3e5a3c8
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions edk2-rockchip/Silicon/Rockchip/RK3588/AcpiTables/Pcie.asl
Original file line number Diff line number Diff line change
Expand Up @@ -80,17 +80,12 @@
SUPP = CDW2 \
CTRL = CDW3 \
\
/* Only allow native hot plug control if OS supports: */ \
/* ASPM */ \
/* Clock PM */ \
/* MSI/MSI-X */ \
If ((SUPP & 0x16) != 0x16) { \
Ctrl &= 0x3E /* Mask bit 0 (and undefined bits) */ \
} \
/* Mask out native hot plug control */ \
CTRL &= 0x1E \
\
/* Always allow native PME, AER and Capability Structure control */ \
/* Never allow SHPC and LTR control */ \
Ctrl &= 0x1D \
CTRL &= 0x1D \
\
/* Unknown revision */ \
If (Arg1 != 1) { \
Expand Down

0 comments on commit 3e5a3c8

Please sign in to comment.