New platform: AIO-3588q #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Windows now sees the sound device as working, but still no actual sound coming out. - CPU fan is now working.
mariobalanica
requested changes
Mar 24, 2024
edk2-rockchip/Platform/Firefly/AIO-3588Q/Library/RockchipPlatformLib/RockchipPlatformLib.c
Show resolved
Hide resolved
- Update README. - Use ComboPhy2 settings from ITX since I'm not sure where the lines go. - Use UsbDpPhy settings from ITX since I'm not sure exactly what they do and the ITX settings seem to work ok. - Enable Usb3Host2 since I'm not sure where the lines go and it doesn't hurt anything. - Remove SdhciEmmcIoMux override since it doesn't seem to be necessary and since other platforms have a "do not override" comment for it. - Remove NorFspiIomux override since this board doesn't have NOR and since other platforms have a "do not override" comment for it. - Fix I2cIomux, mainly fixing up i2c3. - Add reset for PCIE20L0. - Fix blinking LED. - Turn on the headphone output.
mariobalanica
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified working in Windows:
Shows up in Windows but no driver (expected):
Yet to be tested: