Rebasing on main once more

edmondop · Jul 27, 2024 · b60fc73 · b60fc73
1 parent 4ed65a5
commit b60fc73
Show file tree

Hide file tree

Showing 6 changed files with 884 additions and 848 deletions.
diff --git a/datafusion/expr/src/test/function_stub.rs b/datafusion/expr/src/test/function_stub.rs
@@ -373,6 +373,9 @@ impl AggregateUDFImpl for Min {
     fn reverse_expr(&self) -> ReversedUDAF {
         ReversedUDAF::Identical
     }
+    fn get_minmax_desc(&self) -> Option<bool> {
+        Some(false)
+    }
 }
 
 create_func!(Max, max_udaf);
@@ -457,6 +460,9 @@ impl AggregateUDFImpl for Max {
     fn reverse_expr(&self) -> ReversedUDAF {
         ReversedUDAF::Identical
     }
+    fn get_minmax_desc(&self) -> Option<bool> {
+        Some(true)
+    }
 }
 
 /// Testing stub implementation of avg aggregate

diff --git a/datafusion/expr/src/udaf.rs b/datafusion/expr/src/udaf.rs
@@ -249,6 +249,10 @@ impl AggregateUDF {
     pub fn simplify(&self) -> Option<AggregateFunctionSimplification> {
         self.inner.simplify()
     }
+
+    pub fn get_minmax_desc(&self) -> Option<bool> {
+        self.inner.get_minmax_desc()
+    }
 }
 
 impl<F> From<F> for AggregateUDF
@@ -536,6 +540,16 @@ pub trait AggregateUDFImpl: Debug + Send + Sync {
         self.signature().hash(hasher);
         hasher.finish()
     }
+
+    /// If this function is max, return true
+    /// if the function is min, return false
+    /// otherwise return None (the default)
+    ///
+    ///
+    /// Note: this is used to use special aggregate implementations in certain conditions
+    fn get_minmax_desc(&self) -> Option<bool> {
+        None
+    }
 }
 
 pub enum ReversedUDAF {