Load secret key on startup #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow us to drop privileges (via starman command line flags) to a state where we are no longer able to read this file. - Alert users if the variable is set but not valid (fixes edolstra#40).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like others in #10 and #40, I was confused why signatures with
nix-serveweren't working for me.This fixes one possible source of confusion.
Allow us to drop privileges (via starman command line flags) to a state where we are no longer able to read this file. This is useful if the secret key file is only readable by
root, and we don't want to run a network-facing daemon asroot. 🙂Crash with a clear error message on startup if a key is specified, but we are unable to read it (fixes kindly warn on bad values in NIX_SECRET_KEY_FILE #40).