update code to make it compatible with C++17 #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…patibility with C++17
|
Which system does this help for? My system compiler is G++11 which has C++17 by default. The _v variants were added in C++17, so they should be fine with any C++17 compliant compiler. The README is a little out of date. |
The default g++ version of ubuntu 16.04 is 5.4, which doesn't support c++ 17 as default. |
|
The README is old, I don't really support 16.04 any more, officially. Which compiler version do you need the patch for? The main version compiles just fine on GCC 11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems ubuntu 16.04 is quite old. This PR is to make the source compatibility with C++17, which can be compiled in later ubuntu versions. Maybe need to update the README as well.