fix currentWindow keeping reference to old modalstage #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #31
When openModal is called, the default parameter for
owner
iscurrentWindow
which will look for aWindow
in the following order:modalStage
root.scene.window
primaryStage
The first time a modal window is opened the components
currentWindow
will returnprimaryStage
and in theopenModal
function that component will have its root put into a newly built scene and that scene will become the scene of a newly mademodalStage
.When the Modal Stage is closed the component has its modalstage set to null, but its root is still wrapped in a scene which is still the scene of that modal stage so next time openModal is called, the
owner
becomes the previous modal stage (becausecurrentWindow
will look atroot.scene.window
which points to the old modalstage).This old modal stage is now the
owner
and because the owners position determines the starting position of the new modal stage it gets the placement wrong.By removing the component as the root of the scene when closing the stage, it prevents that stage from being referenced by
currentWindow
in the future.