Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework binding function APIs #43

Merged
merged 3 commits into from
Dec 23, 2021
Merged

Rework binding function APIs #43

merged 3 commits into from
Dec 23, 2021

Conversation

aleksandar-stefanovic
Copy link

@aleksandar-stefanovic aleksandar-stefanovic commented Dec 14, 2021 •
edited
Loading

  • Edited all bindings
  • Added comments
  • Added missing nonNullObjectBinding extension function
  • Deleted private fun createObservableArray which has no usages anymore
  • Moved the booleanListBinding function so that all "basic" binding functions are in the same place in code
  • Refactored usages to reflect API changes
  • Add binding functions for ObservableLists

@aleksandar-stefanovic aleksandar-stefanovic marked this pull request as ready for review December 21, 2021 17:14
@SKeeneCode
Copy link
Collaborator

Great stuff. Can you make/change this PR to merge in the new branch 1.0-candidate?

I'm thinking for now it's best to keep breaking changes off master. Once all the major changes have been made we can look into releasing onto maven.

@aleksandar-stefanovic aleksandar-stefanovic changed the base branch from master to 1.0-candidate December 23, 2021 09:31
@aleksandar-stefanovic
Copy link
Author

Done ✅. I did it automatically through GitHub, hopefully it didn't break anything.

@SKeeneCode SKeeneCode linked an issue Dec 23, 2021 that may be closed by this pull request
Binding extension functions are confusing #42
Closed
@SKeeneCode SKeeneCode merged commit 34c637c into edvin:1.0-candidate Dec 23, 2021
@SKeeneCode
Copy link
Collaborator

SKeeneCode commented Dec 23, 2021 •
edited
Loading

Looks good. Tests pass. Excellent work on the comments. Merging. closes #42

@aleksandar-stefanovic aleksandar-stefanovic deleted the bindings branch December 23, 2021 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Binding extension functions are confusing
2 participants
@aleksandar-stefanovic @SKeeneCode