Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temp: Postpone Datadog APM profiling #32

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

rijuma
Copy link
Member

@rijuma rijuma commented Jun 4, 2024

Based on 🔒this slack thread, there's a potential risk on having both Datadog and NewRelic profiling enabled.
Insights was not deployed yet with these options enabled. It would be safer to roll back the changes made in this previous PR #26 before deploying to prod and enable the feature.

@rijuma rijuma requested a review from robrap June 4, 2024 20:34
@robrap
Copy link

robrap commented Jun 4, 2024

@rijuma: Consider changing chore to temp for the commit subject.

@rijuma rijuma marked this pull request as ready for review June 4, 2024 21:34
@rijuma rijuma changed the title chore: Postpone Datadog APM profiling temp: Postpone Datadog APM profiling Jun 4, 2024
@rijuma rijuma force-pushed the rijuma/postpone-datadog-apm-profiling branch from 794f0ba to 95c6f6d Compare June 4, 2024 21:35
@rijuma rijuma merged commit a9560d5 into master Jun 5, 2024
4 checks passed
@rijuma rijuma deleted the rijuma/postpone-datadog-apm-profiling branch June 5, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants