Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove task - Add git apt repository #44

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

robrap
Copy link

@robrap robrap commented Jun 20, 2024

This task is failing, so we are trying to remove it.

It was added 8 years ago to get GitHub version 1.7.10 or later. Presumably this is no longer needed.

3 years ago we added updating the cache, which could still potentially be needed, but hopefully not.

The error from GoCD:

TASK [common : Add git apt repository] *****************************************
FAILED - RETRYING: Add git apt repository (10 retries left).
FAILED - RETRYING: Add git apt repository (9 retries left).
FAILED - RETRYING: Add git apt repository (8 retries left).
FAILED - RETRYING: Add git apt repository (7 retries left).
FAILED - RETRYING: Add git apt repository (6 retries left).
FAILED - RETRYING: Add git apt repository (5 retries left).
FAILED - RETRYING: Add git apt repository (4 retries left).
FAILED - RETRYING: Add git apt repository (3 retries left).
FAILED - RETRYING: Add git apt repository (2 retries left).
FAILED - RETRYING: Add git apt repository (1 retries left).
fatal: [10.4.11.55]: FAILED! => {
    "attempts": 10,
    "changed": false
}

MSG:

failed to fetch PPA information, error was: Request failed: <urlopen error _ssl.c:1114: The handshake operation timed out>

Make sure that the following steps are done before merging:

  • Have a Site Reliability Engineer review the PR if you don't own all of the services impacted.
  • If you are adding any new default values that need to be overridden when this change goes live, update internal repos and add an entry to the top of the CHANGELOG.
  • Performed the appropriate testing.

This task is failing, so we are trying to remove it.

It was added 8 years ago to get GitHub version 1.7.10 or later. Presumably this is no longer needed.

3 years ago we added updating the cache, which could still
potentially be needed, but hopefully not.
@robrap robrap merged commit 8004527 into master Jun 20, 2024
4 checks passed
@robrap robrap deleted the robrap/remove-add-git-apt-repository branch June 20, 2024 14:27
@robrap robrap requested a review from timmc-edx June 20, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants