Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Establish supervisor service dependencies on Datadog #75

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

nadeemshahzad
Copy link
Member

@nadeemshahzad nadeemshahzad commented Oct 4, 2024

Updating the systemd unit file for the supervisor service to ensure that it starts only after the Datadog agent has been successfully initialized and stops before the Datadog agent shuts down
This will mitigate potential issues related to dropped traces by ensuring that the supervisor service stops before the Datadog agent shuts down. This allows the ddtrace run to maintain effective communication with the Datadog socket, reducing the likelihood of losing traces.


Make sure that the following steps are done before merging:

  • Have a Site Reliability Engineer review the PR if you don't own all of the services impacted.
  • If you are adding any new default values that need to be overridden when this change goes live, update internal repos and add an entry to the top of the CHANGELOG.
  • Performed the appropriate testing.

@nadeemshahzad nadeemshahzad merged commit 14f41c1 into master Oct 4, 2024
4 checks passed
@nadeemshahzad nadeemshahzad deleted the fix/supervisor-datadog-dependency branch October 4, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants