feat: latest attempt endpoint fixes #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zacharis278
commented
Aug 4, 2023
| from edx_exams.apps.core.models import Exam, ExamAttempt, ProctoringProvider | ||
| from edx_exams.apps.core.statuses import ExamAttemptStatus | ||
| from edx_exams.apps.core.test_utils.factories import UserFactory |
There was a problem hiding this comment.
Moved this util to core since we really wouldn't want the lti/core apps to depend on the api app.
Zacharis278
commented
Aug 4, 2023
| @@ -38,14 +38,11 @@ def get_attempt_by_id(attempt_id): | |||
| return attempt | |||
|
|
|||
|
|
|||
| def get_latest_attempt_for_user(user_id): | |||
| def get_active_attempt_for_user(user_id): | |||
There was a problem hiding this comment.
renamed this since it's behavior isn't really fetching 'latest' anymore
ilee2u
reviewed
Aug 7, 2023
edx_exams/apps/api/v1/views.py
Outdated
| else: | ||
| attempt = get_active_attempt_for_user(user.id) | ||
|
|
||
| serialized_attempt = StudentAttemptSerializer(attempt) |
There was a problem hiding this comment.
Would it be more efficient for this to be below the if statement block below? I'm thinking we might otherwise end up serializing this attempt twice for no reason.
There was a problem hiding this comment.
good call, there's something odd about that logic here
edx_exams/apps/api/v1/views.py
Outdated
| return Response( | ||
| status=status.HTTP_200_OK, | ||
| data=serialized_attempt.data if latest_attempt is not None else {} | ||
| data=serialized_attempt.data if attempt is not None else {} |
There was a problem hiding this comment.
Would it also be worth maybe checking if attempt is not None here, serializing the data, then sending it back in the response?
Zacharis278
force-pushed
the
zhancock/latest-attempt
branch
from
efb00a1
to
8522887
Compare
ilee2u
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: MST-1950
Frontend PR: openedx/frontend-lib-special-exams#113
Alter the behavior of this endpoint such that:
The story calls for using exam_id here but that could mislead devs troubleshooting or looking at logs in the future since an exam id could be duplicated between edx-exams and edx-proctoring. I chose content id instead since it's unique.
Hindsight, this probably would be less messy as two endpoints but I didn't want to go back on the decisions we've already made or rework the UI. Once edx-proctoring goes away so does 90% of this logic. I've left a note in code and opened https://2u-internal.atlassian.net/browse/MST-2047