Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added ability to handle course errors #18

Merged
merged 4 commits into from
Aug 1, 2024
Merged

feat: added ability to handle course errors #18

merged 4 commits into from
Aug 1, 2024

Conversation

omerhabib26
Copy link

Description:

  • Integrate and parse CourseEnrollmentDetails API
  • Handle CourseAccess Errors on course Dashboard
  • Update UI based on CourseAccess Errors.

figma: https://www.figma.com/design/iZ56YMjbRMShCCDxqrqRrR/Open-edX-Mobile-App-All-Screens-v2.2?node-id=10061-77377&t=Gmoit4lBJxrmRE9f-4

AuditExpiredNotUpgradeable AuditExpiredUpgradeable UnknownError CourseNotYetStarted

@omerhabib26 omerhabib26 mentioned this pull request Jul 25, 2024
Closed
dixidroid
dixidroid reviewed Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@dixidroid dixidroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just small UI inaccuracies

missed details:

The button design does not match Figma (text and landscape mode)

@dixidroid dixidroid mentioned this pull request Jul 26, 2024
Merged
@omerhabib26
Copy link
Author

Hey @dixidroid, Moiz approved these changes as we have to open a Modal for purchase that's why we hide that UI part, and the button design is common for whole app.

@dixidroid dixidroid self-requested a review July 29, 2024 10:13
farhan-arshad-dev
farhan-arshad-dev requested changes Jul 31, 2024
View reviewed changes
Copy link
Member

@farhan-arshad-dev farhan-arshad-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm supposed to review the IAP flow and found the following issue.

Data is not getting refreshed after the completion of IAP flow when the user doesn't have the course access.

@omerhabib26
feat: added ability to handle course errors
c926f2d 
- Integrate and parse CourseEnrollmentDetails API
- Handle CourseAccess Errors on course Dashboard
- Update UI based on CourseAccess Errors.

fix:LEARNER-10019
@omerhabib26
fix: Resolve conflicts
2d855df
@omerhabib26
fix: Resolve failed test cases and a minor bug of parsing
bbd4942
@omerhabib26
fix: Address PR comments
a888978
farhan-arshad-dev
farhan-arshad-dev approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@farhan-arshad-dev farhan-arshad-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The IAP Flow from the course dashboard screen is working fine for me.

@omerhabib26 omerhabib26 merged commit 9e89d94 into 2U/develop Aug 1, 2024
4 checks passed
@omerhabib26 omerhabib26 deleted the omer/LEARNER-10019 branch August 1, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dixidroid dixidroid dixidroid approved these changes

@farhan-arshad-dev farhan-arshad-dev farhan-arshad-dev approved these changes

@HamzaIsrar12 HamzaIsrar12 Awaiting requested review from HamzaIsrar12

@k1rill k1rill Awaiting requested review from k1rill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omerhabib26 @dixidroid @farhan-arshad-dev