Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: signed build issue with R8 full mode #26

Merged
merged 2 commits into from
Aug 1, 2024
Merged

fix: signed build issue with R8 full mode #26

merged 2 commits into from
Aug 1, 2024

Conversation

farhan-arshad-dev
Copy link
Member

@farhan-arshad-dev farhan-arshad-dev commented Jul 31, 2024 •
edited
Loading

Description

LEARNER-10122

  • Enabled R8/Proguard with full mode.
  • Make the signed build acceptable by the Google Play console by fixing the user Permission merging issue.

@farhan-arshad-dev
fix: signed build Manifest issue
58c1f3b 
- Merge uses-permission from Manifest.
- Set R8 full mode to `false`

fixes: LEARNER-10122
@farhan-arshad-dev farhan-arshad-dev marked this pull request as draft July 31, 2024 09:22
@farhan-arshad-dev farhan-arshad-dev marked this pull request as ready for review August 1, 2024 05:31
omerhabib26
omerhabib26 approved these changes Aug 1, 2024
View reviewed changes
Copy link

@omerhabib26 omerhabib26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor nit

course/proguard-rules.pro Show resolved Hide resolved
@dixidroid dixidroid self-requested a review August 1, 2024 14:44
HamzaIsrar12
HamzaIsrar12 reviewed Aug 1, 2024
View reviewed changes
Copy link

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two concerns:

  • The shrinkResources is not set to true.
  • The mappingFileUploadEnabled for Crashlytics is set to false.

Were these changes intentional?

@farhan-arshad-dev
Copy link
Member Author

I have two concerns:

  • The shrinkResources is not set to true.
  • The mappingFileUploadEnabled for Crashlytics is set to false.

Were these changes intentional?

Will consider these as part of the release. For now, just pro-guard things.

@farhan-arshad-dev farhan-arshad-dev merged commit ba8878d into 2U/develop Aug 1, 2024
4 checks passed
@farhan-arshad-dev farhan-arshad-dev deleted the farhan_ar/LEARNER-10122 branch August 1, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HamzaIsrar12 HamzaIsrar12 HamzaIsrar12 left review comments

@k1rill k1rill k1rill approved these changes

@dixidroid dixidroid dixidroid approved these changes

@omerhabib26 omerhabib26 omerhabib26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@farhan-arshad-dev @k1rill @dixidroid @omerhabib26 @HamzaIsrar12 @PavloNetrebchuk