fix: Parity IAP analytics with legacy app #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerhabib26
requested review from
k1rill,
dixidroid,
farhan-arshad-dev and
HamzaIsrar12
dixidroid
approved these changes
Sep 26, 2024
omerhabib26
force-pushed
the
2U/omer/LEARNER-10225
branch
from
4bd998a
to
d2a51cf
Compare
|
Hey @dixidroid & @HamzaIsrar12 , I have rebased the PR with 2U/develop and update the code accordingly. |
HamzaIsrar12
requested changes
Sep 26, 2024
course/src/test/java/org/openedx/course/presentation/container/CourseContainerViewModelTest.kt
Outdated
Show resolved
Hide resolved
HamzaIsrar12
requested changes
Sep 30, 2024
omerhabib26
force-pushed
the
2U/omer/LEARNER-10225
branch
from
bf8e68b
to
6dc5d21
Compare
omerhabib26
force-pushed
the
2U/omer/LEARNER-10225
branch
from
6dc5d21
to
5759db4
Compare
- Update IAP analytics structure. - Update flow_type for all the IAP analytics events - Generalized event triggering in ViewModels fix: LEARNER-10225
- Resolve multiple event triggering due to notifier
HamzaIsrar12
requested changes
Oct 3, 2024
core/src/main/java/org/openedx/core/domain/model/iap/PurchaseFlowData.kt
Outdated
Show resolved
Hide resolved
core/src/main/java/org/openedx/core/system/notifier/UpdateCourseData.kt
Outdated
Show resolved
Hide resolved
core/src/main/java/org/openedx/core/presentation/iap/IAPViewModel.kt
Outdated
Show resolved
Hide resolved
course/src/main/java/org/openedx/course/presentation/container/CourseContainerViewModel.kt
Outdated
Show resolved
Hide resolved
course/src/main/java/org/openedx/course/presentation/container/CourseContainerViewModel.kt
Outdated
Show resolved
Hide resolved
course/src/test/java/org/openedx/course/presentation/container/CourseContainerViewModelTest.kt
Outdated
Show resolved
Hide resolved
profile/src/main/java/org/openedx/profile/presentation/settings/SettingsFragment.kt
Show resolved
Hide resolved
dashboard/src/main/java/org/openedx/courses/presentation/DashboardGalleryViewModel.kt
Outdated
Show resolved
Hide resolved
HamzaIsrar12
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
flow_typefor all the IAP analytics eventsfix: LEARNER-10225