Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Elm theme improvement on Course Home #58

Merged
merged 1 commit into from
Oct 8, 2024
Merged

chore: Elm theme improvement on Course Home #58

merged 1 commit into from
Oct 8, 2024

Conversation

HamzaIsrar12
Copy link

Description

  • The checkmark icon will retain its current design but will now use the color Success-500 (#0D7D4D).
  • The download icon will adopt the Section Title Text color, which for Android is defined as follows:
    • Dark Mode: Paragon Light 200 — #FBFAF9
    • Light Mode: Paragon/Paragon Elm Primary 500 — #00262B
  • The background color of the progress bar will be updated to Grey-500 (#707070) in dark mode.

Screenshots

Dark Mode Light Mode

@omerhabib26
Copy link

LGTM 👍

@HamzaIsrar12
Copy link
Author

Rebased and force-pushed the PR to resolve the test cases.

@HamzaIsrar12 HamzaIsrar12 merged commit 831e021 into 2U/develop Oct 8, 2024
4 checks passed
@HamzaIsrar12 HamzaIsrar12 deleted the hamza/LEARNER-10079 branch October 8, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dixidroid dixidroid dixidroid approved these changes

@omerhabib26 omerhabib26 omerhabib26 approved these changes

@k1rill k1rill Awaiting requested review from k1rill

@farhan-arshad-dev farhan-arshad-dev Awaiting requested review from farhan-arshad-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HamzaIsrar12 @omerhabib26 @dixidroid