This repository has been archived by the owner on May 20, 2019. It is now read-only.
Add support for a score field for feedback response messages #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -340,6 +340,9 @@ def submit_message(request): | |||
| 'recipient': recipient, | |||
| 'message_type': "feedback", | |||
| } | |||
| if 'score' in body: | |||
| message_dict['score'] = body['score'] | |||
There was a problem hiding this comment.
Can you please move this up to the top of the file along with the rest of the "get this value from the request dictionary" stuff?
There was a problem hiding this comment.
Also, would be very good to do some sanity checking on the score to make sure that it is an int. Something like
if 'score' in body: score=body['score']
try: score=int(score), etc...
|
High level--have you tested this out and checked if it works? |
VikParuchuri
added a commit
that referenced
this pull request
Dec 14, 2012
Add support for a score field for feedback response messages
pmitros
pushed a commit
that referenced
this pull request
Jul 12, 2013
Do not double-append the XML path in caps module
cahrens
pushed a commit
that referenced
this pull request
Jul 12, 2013
hides latex compiler in settings tab by making previously specific css s...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.