generated from openedx/frontend-template-application
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added ReviewExamAttemptButton #11
Merged
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
52fc1a4
feat: added ReviewExamAttemptButton
ilee2u 980ccc4
feat: completed reducer, added status filter
ilee2u 7605b11
feat: Improved constants and messages
ilee2u df5c73f
fix: temp workaround for status capitalization
ilee2u ff3e659
fix: separated ui and backend constants
ilee2u 19f45b7
fix: found the stray semicolon
ilee2u 1223452
test: completed tests for this feat
ilee2u 760c481
fix: remove extra console log
ilee2u File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88 changes: 88 additions & 0 deletions
88
src/pages/ExamsPage/components/ReviewExamAttemptButton.jsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| import PropTypes from 'prop-types'; | ||
|
|
||
| import { | ||
| Button, useToggle, ModalDialog, ActionRow, | ||
| } from '@edx/paragon'; | ||
| import { useIntl } from '@edx/frontend-platform/i18n'; | ||
| import { Warning } from '@edx/paragon/icons'; | ||
| import { useModifyExamAttempt } from '../hooks'; | ||
| import messages from '../messages'; | ||
|
|
||
| const ReviewExamAttemptButton = ({ | ||
| username, examName, attemptId, severity, submissionReason, | ||
| }) => { | ||
| const [isOpen, open, close] = useToggle(false); | ||
| const modifyExamAttempt = useModifyExamAttempt(); | ||
| const { formatMessage } = useIntl(); | ||
|
|
||
| return ( | ||
| <> | ||
| <div className="d-flex text-danger"> | ||
| <Button variant="link" size="sm" className="text-danger" onClick={open}> | ||
| <Warning /> | ||
| {formatMessage(messages.ReviewExamAttemptButtonTitle)} | ||
| </Button> | ||
| </div> | ||
| <ModalDialog | ||
| title="my dialog" | ||
| isOpen={isOpen} | ||
| onClose={close} | ||
| size="md" | ||
| variant="default" | ||
| hasCloseButton | ||
| isFullscreenOnMobile | ||
| > | ||
| <ModalDialog.Header> | ||
| <ModalDialog.Title> | ||
| {formatMessage(messages.ReviewExamAttemptButtonModalTitle)} | ||
| </ModalDialog.Title> | ||
| </ModalDialog.Header> | ||
|
|
||
| <ModalDialog.Body> | ||
| {/* TODO: Figure out how to move this formatMessage with the variables. */} | ||
| <p>{formatMessage(messages.ReviewExamAttemptButtonModalBody)}</p> | ||
| <ul> | ||
| <li>{formatMessage(messages.Username)}{username}</li> | ||
| <li>{formatMessage(messages.ExamName)}{examName}</li> | ||
| <li>{formatMessage(messages.SuspicionLevel)}{severity}</li> | ||
| <li>{formatMessage(messages.SubmissionReason)}{submissionReason}</li> | ||
| </ul> | ||
| </ModalDialog.Body> | ||
|
|
||
| <ModalDialog.Footer> | ||
| <ActionRow> | ||
| <ModalDialog.CloseButton variant="tertiary"> | ||
| {formatMessage(messages.ReviewExamAttemptButtonCancel)} | ||
| </ModalDialog.CloseButton> | ||
| <Button | ||
| variant="primary" | ||
| onClick={e => { // eslint-disable-line no-unused-vars | ||
| modifyExamAttempt(attemptId, 'verify'); | ||
| }} | ||
| > | ||
| {formatMessage(messages.ReviewExamAttemptButtonVerify)} | ||
| </Button> | ||
| <Button | ||
| variant="primary" | ||
| onClick={e => { // eslint-disable-line no-unused-vars | ||
| modifyExamAttempt(attemptId, 'reject'); | ||
| }} | ||
| > | ||
| {formatMessage(messages.ReviewExamAttemptButtonReject)} | ||
| </Button> | ||
| </ActionRow> | ||
| </ModalDialog.Footer> | ||
| </ModalDialog> | ||
| </> | ||
| ); | ||
| }; | ||
|
|
||
| ReviewExamAttemptButton.propTypes = { | ||
| username: PropTypes.string.isRequired, | ||
| examName: PropTypes.string.isRequired, | ||
| attemptId: PropTypes.number.isRequired, | ||
| severity: PropTypes.number.isRequired, | ||
| submissionReason: PropTypes.string.isRequired, | ||
| }; | ||
|
|
||
| export default ReviewExamAttemptButton; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry to keep nit picking on these but I think there's two different types of constants that belong in different places. One is just the statuses we get from the backend (so lower/snake case values) and the other is UI labels for those statuses. I think the former makes sense here like the ExamAttemptActions you have above but the UI labels should probably go nearer to the component that's using them and likely named accordingly. I think someone looking at this file the first time would assume these are all the backend values since it's in the data folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've moved the UI label mapping to AttemptsList, and kept the backend string mapping in constants.js