feat: add exam selection component #7
Conversation
varshamenon4
force-pushed
the
varshamenon4/exam-selection-component
branch
from
3e20d3d
to
6cf52e0
Compare
varshamenon4
force-pushed
the
varshamenon4/exam-selection-component
branch
from
d7d864b
to
91101a6
Compare
varshamenon4
force-pushed
the
varshamenon4/exam-selection-component
branch
from
da5a6fd
to
8a3dc5f
Compare
| border: 1px solid $search-border-color !important; | ||
| } | ||
|
|
||
| .pgn__searchfield.has-focus:not(.pgn__searchfield--external)::after { |
There was a problem hiding this comment.
override some of the default styling to deal with putting searchfield inside of a select dropdown. The default focus border looks odd here and causes sizing issues so I've removed it and placed a simple border on the input element instead.
| const { formatMessage } = useIntl(); | ||
| const [searchText, setSearchText] = useState(''); | ||
|
|
||
| const placeholderMessage = formatMessage({ |
There was a problem hiding this comment.
could these messages be moved to a message specific file? I typically haven't seen them defined within the components.
There was a problem hiding this comment.
Also are we considering internationalization?
There was a problem hiding this comment.
oh yeah you're right, this should be done using a separate file.
There was a problem hiding this comment.
ok this should be fixed. Turns out I had already set that file up I just didn't make use of it.
Zacharis278
force-pushed
the
varshamenon4/exam-selection-component
branch
from
935cece
to
52d31fc
Compare
https://2u-internal.atlassian.net/browse/MST-1942