Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgraded to node v18, added .nvmrc and updated workflows #48

Merged
merged 2 commits into from
May 12, 2023

Conversation

Mashal-m
Copy link

@Mashal-m Mashal-m commented Mar 17, 2023

  • Added support for node v18, updated .nvmrc and workflows.
  • Update Semantic Release version

Ticket
Upgrade Node JS from 16 to 18

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2023

Codecov Report

Merging #48 (ced65d5) into master (f0cf088) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #48   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           30        30           
  Branches         6         6           
=========================================
  Hits            30        30           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Mashal-m Mashal-m closed this Mar 24, 2023
@Mashal-m Mashal-m reopened this Mar 24, 2023
@Mashal-m Mashal-m marked this pull request as ready for review March 27, 2023 07:51
Copy link

@abdullahwaheed abdullahwaheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think we need a review from owning squad too.

@Mashal-m Mashal-m marked this pull request as draft April 20, 2023 11:42
@Mashal-m Mashal-m marked this pull request as ready for review April 25, 2023 12:27
Copy link
Member

@Zacharis278 Zacharis278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine 👍

@Zacharis278 Zacharis278 merged commit 6649c41 into master May 12, 2023
@edx-semantic-release
Copy link

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants