Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add assets.txt in pipeline requirements installation #79

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/push-edx-platform-images.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
name: Push edx-platform Docker Images

on:
pull_request:
branches:
- '**'
workflow_dispatch:
inputs:
branch:
Expand Down
2 changes: 2 additions & 0 deletions dockerfiles/edx-platform.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,12 @@
RUN mkdir -p requirements/edx
RUN curl -L -o requirements/pip.txt https://raw.githubusercontent.com/openedx/edx-platform/master/requirements/pip.txt
RUN curl -L -o requirements/edx/base.txt https://raw.githubusercontent.com/openedx/edx-platform/master/requirements/edx/base.txt
RUN curl -L -o requirements/edx/assets.txt https://raw.githubusercontent.com/openedx/edx-platform/master/requirements/edx/assets.txt


RUN pip install -r requirements/pip.txt
RUN pip install -r requirements/edx/base.txt
RUN pip install -r requirements/edx/assets.txt

# Install node and npm
RUN nodeenv /edx/app/edxapp/nodeenv --node=18.19.0 --prebuilt
Expand Down Expand Up @@ -166,7 +168,7 @@
ENV DJANGO_SETTINGS_MODULE="${SERVICE_VARIANT}.envs.$EDX_PLATFORM_SETTINGS"
EXPOSE ${SERVICE_PORT}

CMD gunicorn \

Check warning on line 171 in dockerfiles/edx-platform.Dockerfile

View workflow job for this annotation

GitHub Actions / push (cms, 18010, production)

JSON arguments recommended for ENTRYPOINT/CMD to prevent unintended behavior related to OS signals

JSONArgsRecommended: JSON arguments recommended for CMD to prevent unintended behavior related to OS signals More info: https://docs.docker.com/go/dockerfile/rule/json-args-recommended/

Check warning on line 171 in dockerfiles/edx-platform.Dockerfile

View workflow job for this annotation

GitHub Actions / push (lms, 18010, production)

JSON arguments recommended for ENTRYPOINT/CMD to prevent unintended behavior related to OS signals

JSONArgsRecommended: JSON arguments recommended for CMD to prevent unintended behavior related to OS signals More info: https://docs.docker.com/go/dockerfile/rule/json-args-recommended/
-c /edx/app/edxapp/edx-platform/${SERVICE_VARIANT}/docker_${SERVICE_VARIANT}_gunicorn.py \
--name ${SERVICE_VARIANT} \
--bind=0.0.0.0:${SERVICE_PORT} \
Expand Down Expand Up @@ -198,4 +200,4 @@
ENV EDX_PLATFORM_SETTINGS='devstack_docker'
ENV SERVICE_VARIANT="${SERVICE_VARIANT}"
EXPOSE ${SERVICE_PORT}
CMD ./manage.py ${SERVICE_VARIANT} runserver 0.0.0.0:${SERVICE_PORT}

Check warning on line 203 in dockerfiles/edx-platform.Dockerfile

View workflow job for this annotation

GitHub Actions / push (lms-dev, 18000, development)

JSON arguments recommended for ENTRYPOINT/CMD to prevent unintended behavior related to OS signals

JSONArgsRecommended: JSON arguments recommended for CMD to prevent unintended behavior related to OS signals More info: https://docs.docker.com/go/dockerfile/rule/json-args-recommended/

Check warning on line 203 in dockerfiles/edx-platform.Dockerfile

View workflow job for this annotation

GitHub Actions / push (cms-dev, 18000, development)

JSON arguments recommended for ENTRYPOINT/CMD to prevent unintended behavior related to OS signals

JSONArgsRecommended: JSON arguments recommended for CMD to prevent unintended behavior related to OS signals More info: https://docs.docker.com/go/dockerfile/rule/json-args-recommended/