Skip to content

Commit

Permalink
fix: tweaking var names and tests after rebase
Browse files Browse the repository at this point in the history
  • Loading branch information
christopappas committed Nov 9, 2023
1 parent 235b6d8 commit 070dfea
Show file tree
Hide file tree
Showing 3 changed files with 63 additions and 2 deletions.
2 changes: 1 addition & 1 deletion sanctions/apps/api/v1/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def post(self, request):
city,
country
)
response = {'total': sdn_fallback_hit_count}
sdn_check_response = {'total': sdn_fallback_hit_count}

hit_count = sdn_check_response['total']
if hit_count > 0:
Expand Down
61 changes: 61 additions & 0 deletions sanctions/apps/sanctions/migrations/0003_auto_20231109_2121.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
# Generated by Django 3.2.22 on 2023-11-09 21:21

from django.db import migrations, models


class Migration(migrations.Migration):

dependencies = [
('sanctions', '0002_rename_fallback_models'),
]

operations = [
migrations.RemoveField(
model_name='historicalsanctionscheckfailure',
name='sdn_check_response',
),
migrations.RemoveField(
model_name='sanctionscheckfailure',
name='sdn_check_response',
),
migrations.AddField(
model_name='historicalsanctionscheckfailure',
name='sanctions_response',
field=models.JSONField(null=True),
),
migrations.AddField(
model_name='sanctionscheckfailure',
name='sanctions_response',
field=models.JSONField(null=True),
),
migrations.AlterField(
model_name='historicalsanctionscheckfailure',
name='metadata',
field=models.JSONField(null=True),
),
migrations.AlterField(
model_name='historicalsanctionscheckfailure',
name='system_identifier',
field=models.CharField(max_length=255, null=True),
),
migrations.AlterField(
model_name='historicalsanctionscheckfailure',
name='username',
field=models.CharField(max_length=255, null=True),
),
migrations.AlterField(
model_name='sanctionscheckfailure',
name='metadata',
field=models.JSONField(null=True),
),
migrations.AlterField(
model_name='sanctionscheckfailure',
name='system_identifier',
field=models.CharField(max_length=255, null=True),
),
migrations.AlterField(
model_name='sanctionscheckfailure',
name='username',
field=models.CharField(max_length=255, null=True),
),
]
2 changes: 1 addition & 1 deletion sanctions/apps/sanctions/tests/test_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def test_unicode(self):
sanctions_type='ISN,SDN',
system_identifier='commerce-coordinator',
metadata={'order_identifer': 'EDX-123456', 'purchase_type': 'program', 'order_total': '989.00'},
sdn_check_response=self.sdn_check_response
sanctions_response=self.sdn_check_response
)
expected = 'Sanctions check failure [{username}]'.format(
username=self.username
Expand Down

0 comments on commit 070dfea

Please sign in to comment.