Skip to content

Commit

Permalink
Merge pull request #99 from eea/develop
Browse files Browse the repository at this point in the history
1.5 release
  • Loading branch information
avoinea authored Mar 8, 2022
2 parents 6df09d2 + 2cf23cd commit 592d8db
Show file tree
Hide file tree
Showing 233 changed files with 3,466 additions and 2,078 deletions.
11 changes: 8 additions & 3 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,35 +4,40 @@ about: Create a report to help us improve
title: ''
labels: ''
assignees: ''

---

## React guidelines

### Basic guidelines

- [ ] One React component per file
- [ ] Use best practice naming conventions, follow the library styles (semantic-ui-less, semantic-ui-react).
- [ ] Use best practice naming conventions, follow the library styles (semantic-ui-less, semantic-ui-react).
- [ ] Ensure every file uses Unix line endings

### Naming guidelines

- [ ] Filename: Use PascalCase for filenames. E.g., ItemCard.jsx
- [ ] Variable naming: Use PascalCase for React components and camelCase for their instances
- [ ] Variable naming: Use PascalCase for React components and camelCase for their instances
- [ ] Use the filename as the component name, ReservationCard.jsx should have a reference name of ReservationCard
- [ ] Use camelCase for prop names, or PascalCase if the prop value is a React component

### Component best practice guidelines

- [ ] Don't hard-code values, make them props
- [ ] Avoid using inline styles except for setting background images or visibility of elements
- [ ] Use imports relative to the package name
- [ ] Use whitespace to separate and group imports from other code
- [ ] Large composite components (for example the Footer) should be abstracted and split into multiple subcomponents

### Storybook best practice guidelines

- [ ] Aim for realistic demo aspects, For example, a mix of short and long text.
- [ ] Variations should be provided as separate stories
- [ ] Aim for a comprehensive but realistic set of control options
- [ ] Provide guidelines as to what combinations of props and variations are allowed

## Theming guidelines

- [ ] Style directly the SUI components without introducing new markup or classes
- [ ] Use variables everywhere it is possible
- [ ] Remove or modify overrides to use variables instead of hard-coded values
Expand Down
13 changes: 9 additions & 4 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,38 +4,43 @@ about: Suggest an idea for this project
title: ''
labels: ''
assignees: ''

---

## React guidelines

### Basic guidelines

- [ ] One React component per file
- [ ] Use best practice naming conventions, follow the library styles (semantic-ui-less, semantic-ui-react).
- [ ] Use best practice naming conventions, follow the library styles (semantic-ui-less, semantic-ui-react).
- [ ] Ensure every file uses Unix line endings

### Naming guidelines

- [ ] Filename: Use PascalCase for filenames. E.g., ItemCard.jsx
- [ ] Variable naming: Use PascalCase for React components and camelCase for their instances
- [ ] Variable naming: Use PascalCase for React components and camelCase for their instances
- [ ] Use the filename as the component name, ReservationCard.jsx should have a reference name of ReservationCard
- [ ] Use camelCase for prop names, or PascalCase if the prop value is a React component

### Component best practice guidelines

- [ ] Don't hard-code values, make them props
- [ ] Avoid using inline styles except for setting background images or visibility of elements
- [ ] Use imports relative to the package name
- [ ] Use whitespace to separate and group imports from other code
- [ ] Large composite components (for example the Footer) should be abstracted and split into multiple subcomponents

### Storybook best practice guidelines

- [ ] Aim for realistic demo aspects, For example, a mix of short and long text.
- [ ] Variations should be provided as separate stories
- [ ] Aim for a comprehensive but realistic set of control options
- [ ] Provide guidelines as to what combinations of props and variations are allowed

## Theming guidelines

- [ ] Style directly the SUI components without introducing new markup or classes
- [ ] Use variables everywhere it is possible
- [ ] Remove or modify overrides to use variables instead of hard-coded values
- [ ] Remove or modify overrides to use variables instead of hard-coded values
- [ ] Don't add HTML tags to the css specificity selector
- [ ] Add custom classes after the semantic ui classes
- [ ] Use Semantic UI naming style
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,12 @@ name: Storybook & Docusaurus CI deployment

on:
push:
branches: [ develop-itml ]
branches: [ develop ]
paths:
- src/**
- theme/**
- website/**
- templates/**

jobs:
build:
Expand Down Expand Up @@ -50,7 +51,7 @@ jobs:
github_token: ${{ secrets.PAT_TOKEN }}
owner: 'eea'
repo: 'volto-kitkat-frontend'
ref: 'develop-itml'
ref: 'develop'
workflow_file_name: node.js.yml
- name: Deploy Storybook changes
run: |
Expand Down
Loading

0 comments on commit 592d8db

Please sign in to comment.