Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report subprocess error messages #81

Merged
merged 9 commits into from
Dec 14, 2024
Merged

Conversation

aarmaane
Copy link
Contributor

@aarmaane aarmaane commented Dec 6, 2024

Closes #50. I planned on doing this along with my first PR, but I forgot about it until now.

I appended the error message as-is to the MadoopError. This risks making the error messages a bit cluttered though, so any ideas for a cleaner format are welcome.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 96.98%. Comparing base (042f54b) to head (30214c9).
Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
madoop/mapreduce.py 66.66% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #81      +/-   ##
===========================================
- Coverage    98.43%   96.98%   -1.46%     
===========================================
  Files            4        4              
  Lines          256      265       +9     
===========================================
+ Hits           252      257       +5     
- Misses           4        8       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@awdeorio
Copy link
Contributor

awdeorio commented Dec 6, 2024

Thanks for the contribution! A quick look seems like this is a reasonable approach and thanks for adding tests. I'll take a closer look soon.

Copy link
Contributor

@awdeorio awdeorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after pushing some changes. Take a look and let me know if they look OK to you.

@aarmaane
Copy link
Contributor Author

Pointed out a style choice and added your new messages to the tests. Otherwise, LGTM.

@awdeorio awdeorio merged commit f9f979c into eecs485staff:develop Dec 14, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report error messages from subprocesses
2 participants