2nd attempt to push the simulation of caravan I/O and the #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
correction for the simulation of caravel I/O, since the original push, which was incorrect, got merged already.
|
@RTimothyEdwards Is this still necessary? |
|
@marwaneltoukhy : Yes, this is still relevant and necessary. The simulation make file for caravel has conditionals that will fail if applied to caravan, and no proper test for GPIO pullup/pulldown modes that accounts for the missing GPIO on the caravan padframe. It's possible that nobody except me has attempted to use the pre-cocotb testbenches, but as long as they still exist in the repository for caravel, they should at least work correctly for caravan. |
marwaneltoukhy
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2nd attempt to push the simulation of caravan I/O and the correction to the simulation of caravel I/O, since the original version that was deemed invalid already got merged.