Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated spi_flash (#26) + wishbone test (#24) #27

Closed
wants to merge 0 commits into from
Closed

remove deprecated spi_flash (#26) + wishbone test (#24) #27

wants to merge 0 commits into from

Conversation

suppamax
Copy link

Signed-off-by: Massimiliano Giacometti [email protected]

Solves issue #26

mattvenn
mattvenn approved these changes Mar 14, 2022
View reviewed changes
Copy link

@mattvenn mattvenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to do the same thing.

@suppamax suppamax mentioned this pull request Mar 14, 2022
Open
@suppamax suppamax changed the title remove deprecated spi_flash remove deprecated spi_flash + wishbone test (#24) Mar 14, 2022
@suppamax suppamax changed the title remove deprecated spi_flash + wishbone test (#24) remove deprecated spi_flash (#26) + wishbone test (#24) Mar 14, 2022
@suppamax suppamax closed this Mar 18, 2022
@mattvenn
Copy link

@suppamax did you add the wishbone test - I can't find it.

@suppamax
Copy link
Author

suppamax commented Mar 23, 2022 •
edited
Loading

The test is here.
I don't know why it doesn't show up here.
Let me try to create another PR (#33).

@RTimothyEdwards RTimothyEdwards added the invalid This doesn't seem right label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattvenn mattvenn mattvenn approved these changes

Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suppamax @mattvenn @RTimothyEdwards