Merge pull request #158 from kant2002/kant/tolower

Fix isNullTranstion which chokes if use ToLower
efcore · Nov 21, 2023 · 5bc850d · 5bc850d
2 parents d5f86f0 + 7fb18fb
commit 5bc850d
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 4 deletions.
diff --git a/src/EFCore.FSharp/Translations/IsNullTranslation.fs b/src/EFCore.FSharp/Translations/IsNullTranslation.fs
@@ -9,8 +9,7 @@ let isNullMethodTranslator (sqlExp: ISqlExpressionFactory) =
             if method.DeclaringType.IsValueType then
                 null
             else
-                let expression = arguments |> Seq.head
-
-                match method.Name with
-                | "IsNull" -> sqlExp.IsNull(expression) :> _
+                let expression = arguments |> Seq.tryHead
+                match expression with
+                | Some expression when method.Name = "IsNull" -> sqlExp.IsNull(expression) :> _
                 | _ -> null }
diff --git a/tests/EFCore.FSharp.Tests/Translations/IsNullTranslationTests.fs b/tests/EFCore.FSharp.Tests/Translations/IsNullTranslationTests.fs
@@ -104,6 +104,21 @@ let OptionTranslationQueryTests =
                           headOrDefault
                   }
 
+              Expect.equal blog blogWithContent "Record in context should match"
+          }
+
+          test "Do not break ToLower" {
+              use ctx = createContext ()
+              saveBlogs ctx
+
+              let blog =
+                  query {
+                      for blog in ctx.Blogs do
+                          where (blog.Content.ToLower() = "some text")
+                          select blog
+                          headOrDefault
+                  }
+
               Expect.equal blog blogWithContent "Record in context should match"
           } ]