Changed INameRewriter parameter to align with EF Core IConventionKeyBuilder.Metadata.GetName() return type Issue #279 #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilder.Metadata.GetName() return type of `string?`. Updated all classes that implemented INameRewriter with the updated method signatures.
mattmentrup
changed the title
|
Thanks; to set expectations, I'll only be able to review this much later - I typically do some work on this plugin after major EF/.NET work is already done for the current major release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed INameRewriter parameter to align with EF Core IConventionKeyBuilder.Metadata.GetName() return type of
string?.Updated all classes that implemented INameRewriter with the updated method signatures and handled any spots where a null value could have been referenced before checking if the reference contained a value.