Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed INameRewriter parameter to align with EF Core IConventionKeyBuilder.Metadata.GetName() return type Issue #279 #280

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mattmentrup
Copy link

Changed INameRewriter parameter to align with EF Core IConventionKeyBuilder.Metadata.GetName() return type of string?.

Updated all classes that implemented INameRewriter with the updated method signatures and handled any spots where a null value could have been referenced before checking if the reference contained a value.

…ilder.Metadata.GetName() return type of `string?`.

Updated all classes that implemented INameRewriter with the updated method signatures.
@mattmentrup mattmentrup changed the title Changed INameRewriter parameter to align with EF Core IConventionKeyBuilder.Metadata.GetName() return type Changed INameRewriter parameter to align with EF Core IConventionKeyBuilder.Metadata.GetName() return type Issue #279 May 25, 2024
@roji
Copy link
Member

roji commented May 26, 2024

Thanks; to set expectations, I'll only be able to review this much later - I typically do some work on this plugin after major EF/.NET work is already done for the current major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants