Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto import order suggestions #32

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

peppineddu5
Copy link
Contributor

what

Order of imports is: "./", "../", "@/", "effect-app"

Don't forget to set the version of typescript on Workspace.
image

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@patroza
Copy link
Member

patroza commented Dec 12, 2024

pattern is wrong

@patroza
Copy link
Member

patroza commented Jan 9, 2025

@peppineddu5 I think we should add "effect-app" too, before effect-app/*

regardless doesnt seem to work in frontend vue files
Screenshot 2025-01-09 at 11 19 08
Screenshot 2025-01-09 at 11 25 42

Also isn't preferring the local resources/lib over effect-app it seems:
Screenshot 2025-01-09 at 11 27 18

@peppineddu5
Copy link
Contributor Author

I'm also trying to figure out the problem because the plugin is starting up successfully from the ts-server logs, but when I try to add a log inside the function that reorders the imports, it doesn't start. I've also checked the moveUpPatterns and changed the version of typescript but nothing.
I'll try to see if I can figure out the problem, otherwise I'll send an issue to the pr

@patroza patroza marked this pull request as draft January 10, 2025 11:21
@patroza
Copy link
Member

patroza commented Jan 10, 2025

@peppineddu5 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants