Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

play with vertical slice: controller and resource together in individual feature files #12

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Prev Previous commit
Next Next commit
use full names instead of Request again
  • Loading branch information
patroza committed Jan 19, 2025

Verified

This commit was signed with the committer’s verified signature.
commit 63ec5a5321d7d73c0342b755c80368764451164a
4 changes: 2 additions & 2 deletions api/src/Blog/Create.ts
Original file line number Diff line number Diff line change
@@ -8,13 +8,13 @@ import { InvalidStateError, NotFoundError, OptimisticConcurrencyException } from
import { BlogPost, BlogPostId } from "./models.js"
import { BlogPostRepo } from "./Repo.js"

export class Request extends S.Req<Request>()("Blog.CreatePost", BlogPost.pick("title", "body"), {
export class CreatePost extends S.Req<CreatePost>()("Blog.Create", BlogPost.pick("title", "body"), {
allowRoles: ["user"],
success: S.Struct({ id: BlogPostId }),
failure: S.Union(NotFoundError, InvalidStateError, OptimisticConcurrencyException)
}) {}

export default handlerFor(Request)({
export default handlerFor(CreatePost)({
dependencies: [
BlogPostRepo.Default,
UserRepo.Default,
4 changes: 2 additions & 2 deletions api/src/Blog/Find.ts
Original file line number Diff line number Diff line change
@@ -6,15 +6,15 @@ import { BlogPostId } from "./models.js"
import { BlogPostView } from "./PostView.js"
import { BlogPostRepo } from "./Repo.js"

export class Request extends S.Req<Request>()("Blog.FindPost", {
export class FindPost extends S.Req<FindPost>()("Blog.FindPost", {
id: BlogPostId
}, {
allowAnonymous: true,
allowRoles: ["user"],
success: S.NullOr(BlogPostView)
}) {}

export default handlerFor(Request)({
export default handlerFor(FindPost)({
dependencies: [
BlogPostRepo.Default
],
4 changes: 2 additions & 2 deletions api/src/Blog/List.ts
Original file line number Diff line number Diff line change
@@ -4,15 +4,15 @@ import { Effect } from "effect-app"
import { BlogPostView } from "./PostView.js"
import { BlogPostRepo } from "./Repo.js"

export class Request extends S.Req<Request>()("Blog.List", {}, {
export class ListPosts extends S.Req<ListPosts>()("Blog.List", {}, {
allowAnonymous: true,
allowRoles: ["user"],
success: S.Struct({
items: S.Array(BlogPostView)
})
}) {}

export default handlerFor(Request)({
export default handlerFor(ListPosts)({
dependencies: [
BlogPostRepo.Default
],
6 changes: 3 additions & 3 deletions api/src/Blog/Publish.ts
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
import { handlerFor } from "#api/lib/handler"
import { OperationsDefault } from "#api/lib/layers"
import { Events, Operations } from "#api/services"
import { BogusEvent } from "#resources/Events"
import { S } from "#resources/lib"
import { Events, Operations } from "#api/services"
import { Duration, Effect, Schedule } from "effect-app"
import { NotFoundError } from "effect-app/client"
import { OperationId } from "effect-app/Operations"
import { NonEmptyString2k, NonNegativeInt } from "effect-app/Schema"
import { BlogPostId } from "./models.js"
import { BlogPostRepo } from "./Repo.js"

export class Request extends S.Req<Request>()("Blog.PublishPost", {
export class PublishPost extends S.Req<PublishPost>()("Blog.PublishPost", {
id: BlogPostId
}, { allowRoles: ["user"], success: OperationId, failure: S.Union(NotFoundError) }) {}

export default handlerFor(Request)({
export default handlerFor(PublishPost)({
dependencies: [
BlogPostRepo.Default,
OperationsDefault,
8 changes: 4 additions & 4 deletions api/src/resources/Blog.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
//// codegen:start {preset: barrel, include: ../Blog/*.ts, export: { as: 'PascalCase' }}
export { Request as Create } from "../Blog/Create.js"
export { Request as Find } from "../Blog/Find.js"
export { Request as List } from "../Blog/List.js"
export { Request as Publish } from "../Blog/Publish.js"
export { CreatePost } from "../Blog/Create.js"
export { FindPost } from "../Blog/Find.js"
export { ListPosts } from "../Blog/List.js"
export { PublishPost } from "../Blog/Publish.js"
//// codegen:end

// codegen:start {preset: meta, sourcePrefix: src/resources/}
4 changes: 2 additions & 2 deletions frontend/pages/blog/[id].vue
Original file line number Diff line number Diff line change
@@ -8,7 +8,7 @@ const { id } = useRouteParams({ id: BlogPostId })
const blogClient = clientFor(BlogRsc)
const opsClient = useOperationsClient()

const [r, , reloadPost] = useSafeQuery(blogClient.Find, {
const [r, , reloadPost] = useSafeQuery(blogClient.FindPost, {
id,
})

@@ -28,7 +28,7 @@ const progress = ref("")

const [publishing, publish] = useAndHandleMutation(
mapHandler(
blogClient.Publish,
blogClient.PublishPost,
opsClient.refreshAndWaitForOperation(reloadPost(), op => {
progress.value = `${op.progress?.completed}/${op.progress?.total}`
}),
4 changes: 2 additions & 2 deletions frontend/pages/blog/index.vue
Original file line number Diff line number Diff line change
@@ -4,8 +4,8 @@ import { S } from "effect-app"

const blogClient = clientFor(BlogRsc)

const [, createPost] = useSafeMutation(blogClient.Create)
const [r] = useSafeQuery(blogClient.List)
const [, createPost] = useSafeMutation(blogClient.CreatePost)
const [r] = useSafeQuery(blogClient.ListPosts)
</script>

<template>