Add data field in runner to solve hook ownership issues #337
+26
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into the following problem a couple of times: you try to use some owned value inside the
Runner
hook, but you can't afford to move it into the'static
lifetime closure.Here's a simple example:
Which gives the following error:
This PR adds a custom data field to the
Runner
, so that any value can be moved in and out of the runner, and therefore in and out of the hook closure: