log_entry: replace peers pointer with object #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ehds
commented
Apr 28, 2024
•
ehds
commented
- replace peers pointer with object
- avoid some unnecessary copy
ehds
force-pushed
the
refactor-log-entry
branch
2 times, most recently
from
7cc3b6c to
18d21eb
Compare
ehds
force-pushed
the
refactor-log-entry
branch
from
18d21eb to
05c3d7a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
==========================================
+ Coverage 77.35% 77.75% +0.39%
==========================================
Files 63 63
Lines 9747 9741 -6
Branches 1353 1355 +2
==========================================
+ Hits 7540 7574 +34
+ Misses 2205 2166 -39
+ Partials 2 1 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.